Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix graou schedules import #10676

Merged
merged 3 commits into from
Feb 7, 2025
Merged

front: fix graou schedules import #10676

merged 3 commits into from
Feb 7, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 4, 2025

Close #10501

@Synar Synar requested review from clarani and RomainValls February 4, 2025 15:12
@Synar Synar requested a review from a team as a code owner February 4, 2025 15:12
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (c2135ea) to head (fa524c3).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10676   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files        1079     1079           
  Lines      107412   107444   +32     
  Branches      735      735           
=======================================
+ Hits        87963    87992   +29     
- Misses      19409    19412    +3     
  Partials       40       40           
Flag Coverage Δ
editoast 74.28% <ø> (-0.01%) ⬇️
front 89.40% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo changed the title fix graou schedules import front: fix graou schedules import Feb 4, 2025
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✅

Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested ✅

@Synar Synar requested a review from clarani February 5, 2025 18:26
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Synar Synar added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@Synar Synar added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@Synar Synar force-pushed the ali/fix-graou-schedules-import branch from fa2611a to fa524c3 Compare February 6, 2025 23:42
@Synar Synar enabled auto-merge February 6, 2025 23:43
@Synar Synar added this pull request to the merge queue Feb 7, 2025
Merged via the queue into dev with commit a69c32d Feb 7, 2025
27 checks passed
@Synar Synar deleted the ali/fix-graou-schedules-import branch February 7, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during import - Failed to parse duration
5 participants