Editoast improve valkey connection

[flomonster]

What is done:

1. Remove cluster client
2. Use a pool of connection

Performances are unchanged.

traces.zip

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (85e2e06) to head (a514e9a).
Report is 8 commits behind head on dev.

Files with missing lines	Patch %	Lines
editoast/src/valkey_utils.rs	30.00%	14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev   #10678   +/-   ##
=======================================
  Coverage   81.89%   81.90%           
=======================================
  Files        1078     1078           
  Lines      107201   107163   -38     
  Branches      724      724           
=======================================
- Hits        87795    87767   -28     
+ Misses      19366    19356   -10     
  Partials       40       40           

Flag	Coverage Δ
editoast	74.20% <30.00%> (+0.01%)	⬆️
front	89.45% <ø> (-0.01%)	⬇️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leovalais]

Shouldn't we add a parameter for the number of connections in the pool? The default seems to be num_physical_cpus * 4, but maybe that's too low for what we're trying to do? https://docs.rs/deadpool-redis/latest/deadpool_redis/struct.PoolConfig.html#structfield.max_size

I'm baffled that parallelizing redis calls do not save us transport time 😮 What does the trace timings look like?

[hamz2a]

LGTM, thanks!