front: remove mlg data #10682
Merged
front: remove mlg data #10682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10682 +/- ##
=======================================
Coverage 81.88% 81.89%
=======================================
Files 1078 1078
Lines 107158 107178 +20
Branches 724 724
=======================================
+ Hits 87751 87770 +19
- Misses 19367 19368 +1
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tristram Gräbener <[email protected]>
The constant file only contains colors now (and eslint was complaning about exporting a single value) Signed-off-by: Tristram Gräbener <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use data from http://www.mlgtraffic.net/ to display rolling stock
The rolling stock images are now imported through the API and are we no longer need hard coded things. This pull request removes all unnecessary data to manipulate mlg assets.
I left the credits in https://github.com/OpenRailAssociation/osrd/blob/dev/front/src/common/ReleaseInformations/LicenseAttributions.tsx#L43-L50 as we still use those images