-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: adapt conflicts endpoint to paced trains #10685
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10685 +/- ##
==========================================
- Coverage 81.86% 81.86% -0.01%
==========================================
Files 1082 1082
Lines 107119 107123 +4
Branches 721 721
==========================================
+ Hits 87694 87696 +2
- Misses 19384 19386 +2
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7248a2b
to
3582abe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3582abe
to
b6dcee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for tests/
29dfb51
to
9f84231
Compare
59e63cb
to
1ca3e36
Compare
1ca3e36
to
67cb12a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For core: seems like a simple renaming, I'm not checking further (I trust that this matches the new names used in the payload)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that this shouldn't be merged, I trust everyone else's opinion on the matter (especially if you know the subject). But from the pov of someone who has no idea what's going on, I clearly don't have enough info on this pr: i don't know what a paced train is, the commit has no additional info, description same, linked issue same, and no additional linked issue for additional info.
I'm guessing this is a first PR to pave the way for the following paced train conflict logic that will come in another PR. But yeah, I wouldn't be against having a bit more info somewhere for this sort of PR :)
As for the core part, lgtm, the rename works, and the added field isn't used yet anyhow.
Yeah, agreed - I kind of realize we should've written down a design doc on the website for paced trains… |
There's a confidential issue (https://github.com/osrd-project/osrd-confidential/issues/779). It should be cleaned up and put as a real osrd issue, and ideally we should have a design document on the website indeed. |
67cb12a
to
427c61b
Compare
Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
427c61b
to
35fb47b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm (for front part) and tested :)
Close #10684