Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: clean reducers #10695

Merged
merged 5 commits into from
Feb 6, 2025
Merged

front: clean reducers #10695

merged 5 commits into from
Feb 6, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 5, 2025

closes #6025

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.67782% with 137 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (b3a6f01) to head (e2da186).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
.../operationalStudiesConf/powerRestrictionReducer.ts 6.16% 137 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10695      +/-   ##
==========================================
- Coverage   81.93%   81.93%   -0.01%     
==========================================
  Files        1079     1079              
  Lines      107380   107363      -17     
  Branches      737      735       -2     
==========================================
- Hits        87984    87963      -21     
- Misses      19356    19360       +4     
  Partials       40       40              
Flag Coverage Δ
editoast 74.27% <ø> (-0.01%) ⬇️
front 89.47% <42.67%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/6025-harmonize-sub-reducers branch from 9600a4c to 22d7432 Compare February 6, 2025 08:59
@clarani clarani marked this pull request as ready for review February 6, 2025 09:11
@clarani clarani requested a review from a team as a code owner February 6, 2025 09:11
@clarani clarani requested a review from anisometropie February 6, 2025 11:57
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested 🧹

@clarani clarani force-pushed the cni/6025-harmonize-sub-reducers branch from 22d7432 to e2da186 Compare February 6, 2025 15:29
@clarani clarani enabled auto-merge February 6, 2025 15:31
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested)

@clarani clarani added this pull request to the merge queue Feb 6, 2025
Merged via the queue into dev with commit cf61aae Feb 6, 2025
27 checks passed
@clarani clarani deleted the cni/6025-harmonize-sub-reducers branch February 6, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: remove unused store variables
5 participants