front: create paced train item #10698

Uriel-Sautron · 2025-02-05T16:39:07Z

Use the switch in user parameters to show paced train. Then navigate to a scenario, add at least one train to the timetable you will see, a pacedtrainitem using the same data as the first train of your timetable.

codecov-commenter · 2025-02-05T16:41:39Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 99.57983% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.53%. Comparing base (b77308a) to head (3d4a5f3).
Report is 6 commits behind head on dev.

Files with missing lines	Patch %	Lines
front/src/utils/timeManipulation.ts	33.33%	2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10698      +/-   ##
==========================================
+ Coverage   82.49%   82.53%   +0.03%     
==========================================
  Files        1084     1086       +2     
  Lines      107628   107930     +302     
  Branches      740      740              
==========================================
+ Hits        88786    89078     +292     
- Misses      18800    18810      +10     
  Partials       42       42

Flag	Coverage Δ
editoast	`74.37% <ø> (-0.02%)`	⬇️
front	`90.36% <99.57%> (+0.03%)`	⬆️
gateway	`2.18% <ø> (ø)`
osrdyne	`3.28% <ø> (ø)`
railjson_generator	`87.58% <ø> (ø)`
tests	`87.90% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Caracol3

Good job !
lgtm (tested)

front/src/modules/trainschedule/components/Timetable/PacedTrain/PacedTrainItem.tsx

front/src/modules/trainschedule/components/Timetable/Timetable.tsx

clarani

I think there is more space between the occurences number and the chevron 🤔

The mockup:

front/src/modules/trainschedule/components/Timetable/TimetableItemActions.tsx

front/src/modules/trainschedule/components/Timetable/PacedTrain/PacedTrainItem.tsx

front/src/utils/timeManipulation.ts

front/src/styles/scss/applications/operationalStudies/_scenario.scss

front/src/modules/trainschedule/components/Timetable/TimetableItemActions.tsx

front/src/modules/trainschedule/components/Timetable/Timetable.tsx

front/src/styles/scss/applications/operationalStudies/_scenario.scss

SharglutDev · 2025-02-13T18:34:47Z

Sorry if there are some duplicates with @clarani. Started the review.a while ago :)

front/public/locales/fr/operationalStudies/scenario.json

clarani

Super nice work 💪

Code LGTM, I just found this small scroll bar (I had my dev tools opened, but it was not very wide)
Capture vidéo du 2025-02-21 17-26-07.webm

front/public/locales/fr/operationalStudies/scenario.json

front/src/modules/trainschedule/components/Timetable/Timetable.tsx

front/src/modules/trainschedule/components/Timetable/TimetableToolbar.tsx

Uriel-Sautron · 2025-02-24T09:30:06Z

Fix scroll bar @clarani

front/src/modules/trainschedule/components/Timetable/PacedTrain/PacedTrainItem.tsx

SharglutDev

Lgtm and tested, great job !

Co-authored-by: Uriel-Sautron <[email protected]> Signed-off-by: Math_R_ <[email protected]>

SharglutDev · 2025-02-24T13:55:50Z

It would be nice for your 3rd commit if he kept only the changes regarding TrainScheduleItem

Co-authored-by: Uriel-Sautron <[email protected]> Signed-off-by: Math_R_ <[email protected]> - adapt selection timetable for paced train

Co-authored-by: Math_R_ <[email protected]> Signed-off-by: Uriel-Sautron <[email protected]>

clarani

LGTM ✅

github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 5, 2025

Uriel-Sautron force-pushed the usn/create-paced-train-item branch from 3fe4c05 to 6ef4022 Compare February 6, 2025 10:55

Math-R force-pushed the usn/create-paced-train-item branch from 6ef4022 to 559c26a Compare February 10, 2025 13:52

Uriel-Sautron force-pushed the usn/create-paced-train-item branch from 559c26a to 7a548a0 Compare February 10, 2025 14:08

Math-R force-pushed the usn/create-paced-train-item branch 6 times, most recently from 131078d to 6a1f99e Compare February 11, 2025 15:57

Math-R changed the title ~~front: wip: create paced train item~~ front: create paced train item Feb 11, 2025

Math-R assigned Math-R and Uriel-Sautron Feb 11, 2025

Math-R requested review from emersion and Caracol3 February 11, 2025 15:58

Math-R marked this pull request as ready for review February 11, 2025 15:58

Math-R requested a review from a team as a code owner February 11, 2025 15:58

Math-R force-pushed the usn/create-paced-train-item branch from 6a1f99e to 85b8afd Compare February 11, 2025 16:11

Uriel-Sautron force-pushed the usn/create-paced-train-item branch from 85b8afd to 29aa2a4 Compare February 12, 2025 11:03

Caracol3 approved these changes Feb 12, 2025

View reviewed changes

Math-R requested review from kmer2016 and clarani February 13, 2025 11:03

Math-R force-pushed the usn/create-paced-train-item branch from 29aa2a4 to d919fc9 Compare February 13, 2025 11:16

clarani reviewed Feb 13, 2025

View reviewed changes

SharglutDev reviewed Feb 13, 2025

View reviewed changes

emersion removed their request for review February 17, 2025 09:23

Math-R force-pushed the usn/create-paced-train-item branch from cc03c7c to 37715fb Compare February 17, 2025 10:59

Uriel-Sautron force-pushed the usn/create-paced-train-item branch from faa9955 to ad6d531 Compare February 21, 2025 13:06

SharglutDev reviewed Feb 21, 2025

View reviewed changes

front/public/locales/fr/operationalStudies/scenario.json Show resolved Hide resolved

clarani reviewed Feb 21, 2025

View reviewed changes

Uriel-Sautron force-pushed the usn/create-paced-train-item branch 3 times, most recently from d3a9022 to c2b8031 Compare February 24, 2025 10:59

Uriel-Sautron requested review from clarani and SharglutDev February 24, 2025 10:59

SharglutDev reviewed Feb 24, 2025

View reviewed changes

front/src/modules/trainschedule/components/Timetable/PacedTrain/PacedTrainItem.tsx Outdated Show resolved Hide resolved

Uriel-Sautron force-pushed the usn/create-paced-train-item branch from c2b8031 to dbc24ed Compare February 24, 2025 12:53

Uriel-Sautron requested a review from SharglutDev February 24, 2025 12:53

SharglutDev approved these changes Feb 24, 2025

View reviewed changes

front: create timetable item action component

5911093

Co-authored-by: Uriel-Sautron <[email protected]> Signed-off-by: Math_R_ <[email protected]>

Uriel-Sautron force-pushed the usn/create-paced-train-item branch 2 times, most recently from f62f292 to 69402ab Compare February 24, 2025 13:52

Uriel-Sautron force-pushed the usn/create-paced-train-item branch 3 times, most recently from 5bdc63d to 2d660e5 Compare February 24, 2025 15:04

Math-R and others added 2 commits February 24, 2025 16:06

front: create paced train item

1ac3a74

Co-authored-by: Uriel-Sautron <[email protected]> Signed-off-by: Math_R_ <[email protected]> - adapt selection timetable for paced train

front: replace timetabletraincard by trainscheduleitem

3d4a5f3

Co-authored-by: Math_R_ <[email protected]> Signed-off-by: Uriel-Sautron <[email protected]>

Uriel-Sautron force-pushed the usn/create-paced-train-item branch from 2d660e5 to 3d4a5f3 Compare February 24, 2025 15:06

clarani approved these changes Feb 24, 2025

View reviewed changes

Math-R added this pull request to the merge queue Feb 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025

Math-R added this pull request to the merge queue Feb 24, 2025

Merged via the queue into dev with commit a683167 Feb 24, 2025
27 checks passed

Math-R deleted the usn/create-paced-train-item branch February 24, 2025 17:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

front: create paced train item #10698

front: create paced train item #10698

Uriel-Sautron commented Feb 5, 2025 •

edited by Math-R

Loading

codecov-commenter commented Feb 5, 2025 •

edited

Loading

Caracol3 left a comment

clarani left a comment

SharglutDev commented Feb 13, 2025 •

edited

Loading

clarani left a comment

Uriel-Sautron commented Feb 24, 2025

SharglutDev left a comment

SharglutDev commented Feb 24, 2025

clarani left a comment

front: create paced train item #10698

front: create paced train item #10698

Conversation

Uriel-Sautron commented Feb 5, 2025 • edited by Math-R Loading

codecov-commenter commented Feb 5, 2025 • edited Loading

Codecov Report

Caracol3 left a comment

Choose a reason for hiding this comment

clarani left a comment

Choose a reason for hiding this comment

SharglutDev commented Feb 13, 2025 • edited Loading

clarani left a comment

Choose a reason for hiding this comment

Uriel-Sautron commented Feb 24, 2025

SharglutDev left a comment

Choose a reason for hiding this comment

SharglutDev commented Feb 24, 2025

clarani left a comment

Choose a reason for hiding this comment

Uriel-Sautron commented Feb 5, 2025 •

edited by Math-R

Loading

codecov-commenter commented Feb 5, 2025 •

edited

Loading

SharglutDev commented Feb 13, 2025 •

edited

Loading