Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: simplify rolling stock form type #10699

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 5, 2025

Simplify type RollingStockParametersValues in the front rolling stock editor and solve the corresponding todo

@Synar Synar requested a review from a team as a code owner February 5, 2025 17:34
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (c2135ea) to head (673ab84).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10699      +/-   ##
==========================================
- Coverage   81.89%   81.89%   -0.01%     
==========================================
  Files        1079     1079              
  Lines      107412   107409       -3     
  Branches      735      734       -1     
==========================================
- Hits        87963    87960       -3     
  Misses      19409    19409              
  Partials       40       40              
Flag Coverage Δ
editoast 74.29% <ø> (ø)
front 89.40% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I will test once docker is up again

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Synar Synar enabled auto-merge February 6, 2025 12:11
@Synar Synar force-pushed the ali/simplify-rolling-stock-form-typescript-type branch from 7193f5b to 673ab84 Compare February 6, 2025 23:40
@Synar Synar self-assigned this Feb 6, 2025
@Synar Synar added this pull request to the merge queue Feb 6, 2025
Merged via the queue into dev with commit 673ab84 Feb 7, 2025
53 checks passed
@Synar Synar deleted the ali/simplify-rolling-stock-form-typescript-type branch February 7, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants