front: enable import/no-extraneous-dependencies lint #10707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synar
reviewed
Feb 6, 2025
Don't use the .tsx file extension, because there's no JSX in there. While at it, use .spec.ts instead of .test.ts since it's the more widely used suffix. Signed-off-by: Simon Ser <[email protected]>
We don't use moment anywhere. Signed-off-by: Simon Ser <[email protected]>
This is the pattern used everywhere else. Signed-off-by: Simon Ser <[email protected]>
fail() is a jest-ism. We need to use assert.fail() with vitest.
Fixes the following error when @types/jest is dropped:
/home/simon/src/osrd/front/src/common/IntervalsDataViz/data.spec.ts
272:9 warning Unsafe call of a(n) `error` type typed value @typescript-eslint/no-unsafe-call
287:9 warning Unsafe call of a(n) `error` type typed value @typescript-eslint/no-unsafe-call
302:9 warning Unsafe call of a(n) `error` type typed value @typescript-eslint/no-unsafe-call
Signed-off-by: Simon Ser <[email protected]>
We use vitest for testing, not jest. Remove all remaining references to jest. Signed-off-by: Simon Ser <[email protected]>
This is a valuable lint to figure out cases where we're missing a dependency (and only get it by chance because another dependency pulls it in). Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/import-no-extra-deps
branch
from
219cd85 to
52f6d6d
Compare
clarani
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a valuable lint to figure out cases where we're missing a
dependency (and only get it by chance because another dependency
pulls it in).
See individual commits.