Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: do not display errors layer by default in the infra editor #10708

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 6, 2025

closes #6711

@clarani clarani requested a review from a team as a code owner February 6, 2025 13:22
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (716e6c8) to head (aa5bd09).
Report is 13 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10708   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files        1079     1079           
  Lines      107233   107270   +37     
  Branches      729      737    +8     
=======================================
+ Hits        87840    87874   +34     
- Misses      19353    19356    +3     
  Partials       40       40           
Flag Coverage Δ
editoast 74.20% <ø> (-0.02%) ⬇️
front 89.47% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@clarani clarani added this pull request to the merge queue Feb 6, 2025
Merged via the queue into dev with commit 66a9cad Feb 6, 2025
27 checks passed
@clarani clarani deleted the cni/6711-disable-errors-display-by-default-in-editor branch February 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When opening the editor don't show the warnings
4 participants