Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: lower the visited margin even lower #10712

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Feb 6, 2025

Fix #10658

But it's weird we need this value to be that low, I'll open a different issue: #10713

@eckter eckter requested a review from a team as a code owner February 6, 2025 14:21
@eckter eckter requested a review from Khoyo February 6, 2025 14:21
@github-actions github-actions bot added the area:core Work on Core Service label Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (9f2a3bf) to head (4e4a179).
Report is 46 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10712      +/-   ##
==========================================
- Coverage   81.92%   81.92%   -0.01%     
==========================================
  Files        1079     1079              
  Lines      107274   107274              
  Branches      737      737              
==========================================
- Hits        87882    87879       -3     
- Misses      19352    19355       +3     
  Partials       40       40              
Flag Coverage Δ
editoast 74.20% <ø> (-0.01%) ⬇️
front 89.47% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter requested a review from Erashin February 10, 2025 09:30
@eckter eckter added this pull request to the merge queue Feb 10, 2025
Merged via the queue into dev with commit eeb8aa2 Feb 10, 2025
27 checks passed
@eckter eckter deleted the ech/lower-visited-margin branch February 10, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: stdcm: engineering allowances last for longer than necessary
3 participants