-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: update modified
field of infra
upon modification
#10716
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10716 +/- ##
==========================================
- Coverage 81.93% 81.92% -0.01%
==========================================
Files 1079 1079
Lines 107376 107533 +157
Branches 737 734 -3
==========================================
+ Hits 87978 88096 +118
- Misses 19358 19397 +39
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7ea122b
to
7a609ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left a small suggestion for a non-blocking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving that logic to the DB so we don't forget to put it in every places in the code that needs it? I usually don't like putting logic in the DB, but in this case, it looks almost like a missing feature of Postgres (MySQL seems to have syntactic sugar for it).
7a609ef
to
67b2180
Compare
The field used to default to `NOW()` on `INSERT`, but was never updated. Naive datetimes are also replaced by `DateTime<Utc>`. Signed-off-by: Leo Valais <[email protected]>
67b2180
to
23c96c1
Compare
Part of
editoast-statful
scalability work.The field used to default to
NOW()
onINSERT
, but was never updated.Naive datetimes are also replaced by
DateTime<Utc>
.