front: don't use front/tests/ to write PDF files #10718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/test-pdf-output
branch
from
c7aa080 to
eee64d9
Compare
Maymanaf
reviewed
Feb 7, 2025
Maymanaf
approved these changes
Feb 7, 2025
front/tests/ is not a directory meant to be used for test results. It should only contain source files. Playwright sets up a specific directory for test outputs, so we can just use that instead. As a bonus, the PDF is now included in CI artifacts and can be inspected manually if needed. Fixes permission errors when running tests in a container for me. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/test-pdf-output
branch
from
eee64d9 to
7b9373d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10492
front/tests/ is not a directory meant to be used for test results. It should only contain source files.
Playwright sets up a specific directory for test outputs, so we can just use that instead. As a bonus, the PDF is now included in CI artifacts and can be inspected manually if needed.
Fixes permission errors when running tests in a container for me.