front: fail E2E test if PDF download fails in downloadSimulation() #10719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maymanaf
approved these changes
Feb 10, 2025
downloadSimulation() was logging an error and silently continuing the tests on failure. CI wouldn't complain in that case. Don't catch the error to ensure that we notice when the function fails. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/pdf-dl-check
branch
from
908be70 to
303861b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downloadSimulation() was logging an error and silently continuing the tests on failure. CI wouldn't complain in that case.
Don't catch the error to ensure that we notice when the function fails.