Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: rename front to front-dev in osrd-compose #10721

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Feb 7, 2025

In order to avoid confusions on commands like osrd-compose front up front.

After those changes it would be osrd-compose dev-front up front

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (14fa21b) to head (d1b45dc).
Report is 18 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10721      +/-   ##
==========================================
+ Coverage   81.90%   81.91%   +0.01%     
==========================================
  Files        1079     1079              
  Lines      107473   107471       -2     
  Branches      734      734              
==========================================
+ Hits        88024    88034      +10     
+ Misses      19409    19397      -12     
  Partials       40       40              
Flag Coverage Δ
editoast 74.32% <ø> (+0.03%) ⬆️
front 89.41% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you

@ElysaSrc ElysaSrc added this pull request to the merge queue Feb 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2025
@ElysaSrc ElysaSrc added this pull request to the merge queue Feb 8, 2025
Merged via the queue into dev with commit 87d186e Feb 8, 2025
27 checks passed
@ElysaSrc ElysaSrc deleted the ev/rename-frontdev branch February 8, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants