Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add unique map #10722

Merged
merged 6 commits into from
Feb 12, 2025
Merged

front: add unique map #10722

merged 6 commits into from
Feb 12, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 7, 2025

closes #6019

@clarani clarani requested a review from a team as a code owner February 7, 2025 12:33
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 99.10913% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (a0c88c3) to head (79f8a4d).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/common/Map/Layers/IGNLayers/index.ts 0.00% 1 Missing and 1 partial ⚠️
front/src/common/Map/Layers/OSMLayers/index.ts 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10722      +/-   ##
==========================================
- Coverage   81.94%   81.86%   -0.08%     
==========================================
  Files        1077     1082       +5     
  Lines      107483   107093     -390     
  Branches      727      729       +2     
==========================================
- Hits        88074    87674     -400     
- Misses      19370    19378       +8     
- Partials       39       41       +2     
Flag Coverage Δ
editoast 74.30% <ø> (-0.02%) ⬇️
front 89.41% <99.10%> (-0.07%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/6019-unique-map branch 2 times, most recently from ab7001d to fc96cf6 Compare February 7, 2025 17:24
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ! Only some small/nit comments

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Juste small suggestions

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@clarani clarani force-pushed the cni/6019-unique-map branch from 72170d8 to 0d00d5f Compare February 12, 2025 10:28
@clarani clarani force-pushed the cni/6019-unique-map branch from 0d00d5f to 79f8a4d Compare February 12, 2025 10:30
@clarani clarani enabled auto-merge February 12, 2025 10:52
@clarani clarani added this pull request to the merge queue Feb 12, 2025
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

Merged via the queue into dev with commit f94fce3 Feb 12, 2025
27 checks passed
@clarani clarani deleted the cni/6019-unique-map branch February 12, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: refacto map component across the entire application
4 participants