-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add unique map #10722
front: add unique map #10722
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10722 +/- ##
==========================================
- Coverage 81.94% 81.86% -0.08%
==========================================
Files 1077 1082 +5
Lines 107483 107093 -390
Branches 727 729 +2
==========================================
- Hits 88074 87674 -400
- Misses 19370 19378 +8
- Partials 39 41 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ab7001d
to
fc96cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice ! Only some small/nit comments
front/src/modules/simulationResult/components/SimulationResultsMap/SimulationResultsMap.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Juste small suggestions
front/src/modules/simulationResult/components/SimulationResultsMap/SimulationResultsMap.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job !
72170d8
to
0d00d5f
Compare
No behavior change. Signed-off-by: Clara Ni <[email protected]>
No behavior change. Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
0d00d5f
to
79f8a4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
closes #6019