front: fix some trigrams are not recognized #10729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the search endpoint response is paginated, when the user searches a short string, the search endpoint will return some of the operational points which match either the trigram or the name. As the search endpoint response is not ordered by trigram first, we could miss some responses, and especially the operational points corresponding by trigram. Now, if the user searches a short string, we will first get all the operational points matching the trigram and then the ones matching the name. This way, we won't miss the reponse by trigram anymore. Signed-off-by: Clara Ni <[email protected]>
clarani
requested review from
emersion,
flomonster,
theocrsb and
SharglutDev
and removed request for
emersion
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10729 +/- ##
=======================================
Coverage 81.93% 81.93%
=======================================
Files 1079 1079
Lines 107550 107576 +26
Branches 734 734
=======================================
+ Hits 88116 88139 +23
- Misses 19394 19397 +3
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emersion
reviewed
Feb 10, 2025
SharglutDev
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10668
Since the search endpoint response is paginated, when the user searches a short string, the search endpoint will return some of the operational points which match either the trigram or the name. As the search endpoint response is not ordered by trigram first, we could miss some responses, and especially the operational points matching by trigram.
Now, if the user searches a short string, we will first get all the operational points matching the trigram and then the ones matching the name. This way, we won't miss the reponse by trigram anymore.