Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix prettier formatting of jsonc #10736

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 9, 2025

  • Fix prettier adding trailing commas to jsonc, which is incorrect for jsonc specs
  • Thus formats .eslintrc with prettier, without any commas addition

See the related prettier issue

@Synar Synar requested a review from a team as a code owner February 9, 2025 23:47
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (42f1939) to head (f3bba6d).
Report is 44 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10736   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files        1078     1078           
  Lines      107544   107544           
  Branches      733      733           
=======================================
+ Hits        88114    88115    +1     
+ Misses      19391    19390    -1     
  Partials       39       39           
Flag Coverage Δ
editoast 74.39% <ø> (+<0.01%) ⬆️
front 89.41% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar Synar self-assigned this Feb 10, 2025
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Synar Synar added this pull request to the merge queue Feb 12, 2025
Merged via the queue into dev with commit a7ca664 Feb 12, 2025
27 checks passed
@Synar Synar deleted the ali/fix-jsonc-prettier-format-in-front branch February 12, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants