Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add error on zero length simulations #10738

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Feb 10, 2025

We sometimes have 500 errors in prod because of this

@eckter eckter requested a review from Erashin February 10, 2025 13:51
@eckter eckter requested a review from a team as a code owner February 10, 2025 13:51
@github-actions github-actions bot added the area:core Work on Core Service label Feb 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (eeb8aa2) to head (c8a0b05).
Report is 12 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10738      +/-   ##
==========================================
- Coverage   81.93%   81.93%   -0.01%     
==========================================
  Files        1078     1078              
  Lines      107555   107555              
  Branches      733      733              
==========================================
- Hits        88125    88123       -2     
- Misses      19391    19393       +2     
  Partials       39       39              
Flag Coverage Δ
editoast 74.38% <ø> (-0.01%) ⬇️
front 89.42% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/add-error-zero-length branch from 4b47ed0 to c8a0b05 Compare February 10, 2025 14:59
@emersion
Copy link
Member

Weird that we're still seeing this, editoast should avoid sending such requests now: #9931

I suppose more safety is always a good thing :P

@eckter
Copy link
Contributor Author

eckter commented Feb 11, 2025

Yeah we should investigate further, I'll create a different issue: #10762

But when it does happen, an exception is better than an assert error very far down the call stack

@eckter eckter added this pull request to the merge queue Feb 11, 2025
Merged via the queue into dev with commit 4f0a800 Feb 11, 2025
27 checks passed
@eckter eckter deleted the ech/add-error-zero-length branch February 11, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants