Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm - show consist tooltip on focus out only #10740

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Feb 10, 2025

close #9374

fix this comment in the issue : #9374 (comment)

  • Update ConsistError type to be able to display them or not depending on
    some conditions
  • Transform consistErrors useMemo into a state and move it in StdcmConsist component

To test the PR :

  • the tooltip error should not pop unless the input is focus out if the value is invalid (doesn't match the range)
  • the tooltip should hide if the value becomes correct but not show again if it was corrected and then invalid (unless focus out)

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (3f83ed4) to head (97eaf2e).
Report is 18 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10740   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files        1081     1081           
  Lines      106882   106906   +24     
  Branches      729      729           
=======================================
+ Hits        87469    87490   +21     
- Misses      19372    19375    +3     
  Partials       41       41           
Flag Coverage Δ
editoast 74.31% <ø> (-0.01%) ⬇️
front 89.38% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/stdcm-show-consist-tootip-on-blur branch 2 times, most recently from 33f979a to eb5b5cd Compare February 12, 2025 17:16
- Update ConsistError type to be able to display them or not depending on
some conditions
- Transform consistErrors useMemo into a state and move it in StdcmConsist component

Signed-off-by: SharglutDev <[email protected]>
@SharglutDev SharglutDev force-pushed the pfn/front/stdcm-show-consist-tootip-on-blur branch from eb5b5cd to 97eaf2e Compare February 12, 2025 17:19
@SharglutDev SharglutDev marked this pull request as ready for review February 12, 2025 17:25
@SharglutDev SharglutDev requested a review from a team as a code owner February 12, 2025 17:25
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the test instructions, LGTM !

@SharglutDev SharglutDev added this pull request to the merge queue Feb 13, 2025
Merged via the queue into dev with commit b748403 Feb 13, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/stdcm-show-consist-tootip-on-blur branch February 13, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle invalid values in stdcm inputs
4 participants