Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: support electrification overlaps #10763

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Feb 11, 2025

Fix a subset of #6451. I'll update this issue once it's merged to track what's left.

Makes https://github.com/osrd-project/osrd-confidential/issues/946 easier.

@eckter eckter requested a review from a team as a code owner February 11, 2025 11:02
@eckter eckter requested a review from Erashin February 11, 2025 11:02
@github-actions github-actions bot added the area:core Work on Core Service label Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.96%. Comparing base (a98e13c) to head (95c6c3f).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10763      +/-   ##
==========================================
- Coverage   81.96%   81.96%   -0.01%     
==========================================
  Files        1076     1076              
  Lines      107551   107551              
  Branches      731      731              
==========================================
- Hits        88156    88154       -2     
- Misses      19356    19358       +2     
  Partials       39       39              
Flag Coverage Δ
editoast 74.39% <ø> (-0.01%) ⬇️
front 89.46% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the support-electrification-overlap branch from 8b3b627 to 95c6c3f Compare February 11, 2025 11:46
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first step gj.

@eckter eckter added this pull request to the merge queue Feb 11, 2025
@eckter eckter removed this pull request from the merge queue due to a manual request Feb 11, 2025
@eckter eckter added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@eckter eckter added this pull request to the merge queue Feb 11, 2025
Merged via the queue into dev with commit b811054 Feb 11, 2025
27 checks passed
@eckter eckter deleted the support-electrification-overlap branch February 11, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants