front: fix rounded hours

[Akctarus]

closes #9179

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (3ebcea2) to head (4ece033).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10766      +/-   ##
==========================================
- Coverage   82.53%   82.53%   -0.01%     
==========================================
  Files        1086     1086              
  Lines      107928   107931       +3     
  Branches      740      740              
==========================================
- Hits        89080    89077       -3     
- Misses      18806    18812       +6     
  Partials       42       42              

Flag	Coverage Δ
editoast	74.37% <ø> (-0.02%)	⬇️
front	90.36% <100.00%> (+<0.01%)	⬆️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.58% <ø> (ø)
tests	87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emersion]

Weird, I think dayjs is already expected to handle this case?

https://day.js.org/docs/en/customization/relative-time#relative-time-thresholds-and-rounding

[Akctarus]

Weird, I think dayjs is already expected to handle this case?

https://day.js.org/docs/en/customization/relative-time#relative-time-thresholds-and-rounding

dayjs has built-in rounding behaviors, but by default, it does not round up minutes when seconds are >=30

[emersion]

Right, but it can be configured to do so, right? (See above link)

[Akctarus]

Right, but it can be configured to do so, right? (See above link)

you mean something like that ? fc1ebcd

[emersion]

Ew, my bad, it seems like the options I've linked to only apply to the relative time plugin, which we don't use.

Ideally we'd use a rounding function (just like Temporal has) but it seems like the library is missing that.

Oh well, let's just go with your original solution then, sorry for the noise!

[Akctarus]

@emersion Done !

[emersion]

LGTM!

Ideally these commits would be squashed together so that the tests don't regress in-between the commits (useful when bisecting).