Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix itinerary marker not always defined #10770

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

theocrsb
Copy link
Contributor

closes #10414

@theocrsb theocrsb requested a review from a team as a code owner February 11, 2025 16:13
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (ece353f) to head (1802311).
Report is 25 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10770      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107212   107216       +4     
  Branches      737      737              
==========================================
  Hits        87842    87842              
- Misses      19329    19333       +4     
  Partials       41       41              
Flag Coverage Δ
editoast 74.37% <ø> (-0.02%) ⬇️
front 89.49% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Math-R
Copy link
Contributor

Math-R commented Feb 13, 2025

Sorry but the bug still occure here it's a footage

Enregistrement.de.l.ecran.2025-02-13.a.11.21.07.mov

@axrolld
Copy link
Contributor

axrolld commented Feb 17, 2025

@Math-R i think when there's no pathfinding we should not display the small cards with the tracks, only the pins with numbers 1, 2, 3, etc. @theocrsb agrees with that.

@theocrsb theocrsb force-pushed the tce/bug/intinerary-marker-not-always-defined branch from 06b8c94 to 07a40bf Compare February 17, 2025 13:35
@theocrsb theocrsb force-pushed the tce/bug/intinerary-marker-not-always-defined branch from 07a40bf to 1802311 Compare February 17, 2025 13:36
@theocrsb
Copy link
Contributor Author

I just pushed with the modifications

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and lgtm ! I find it much cleaner and easier to understand

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay till the comportement as been discuss, it looks good to me

@theocrsb theocrsb added this pull request to the merge queue Feb 18, 2025
Merged via the queue into dev with commit b9d58a0 Feb 18, 2025
28 checks passed
@theocrsb theocrsb deleted the tce/bug/intinerary-marker-not-always-defined branch February 18, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Itinerary marker not always defined
5 participants