Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove blueprint map style #10771

Merged
merged 1 commit into from
Feb 12, 2025
Merged

front: remove blueprint map style #10771

merged 1 commit into from
Feb 12, 2025

Conversation

Tristramg
Copy link
Contributor

@Tristramg Tristramg commented Feb 11, 2025

This style existed for a schematic representation that no longer exists.

It added some complexity to handle specific sprites and one sprite was missing (SECT) and nobody ever noticed it.

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (0a2b1ab) to head (4f03d46).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10771      +/-   ##
==========================================
- Coverage   81.87%   81.83%   -0.04%     
==========================================
  Files        1082     1081       -1     
  Lines      107089   106882     -207     
  Branches      729      729              
==========================================
- Hits        87676    87466     -210     
- Misses      19372    19375       +3     
  Partials       41       41              
Flag Coverage Δ
editoast 74.31% <ø> (-0.01%) ⬇️
front 89.38% <100.00%> (-0.04%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tristramg Tristramg marked this pull request as ready for review February 12, 2025 09:12
@Tristramg Tristramg requested a review from a team as a code owner February 12, 2025 09:12
@Tristramg Tristramg requested review from Math-R and a team February 12, 2025 09:25
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! thanks for the cleanup :D

@Tristramg Tristramg requested a review from a team as a code owner February 12, 2025 14:46
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 12, 2025
Signed-off-by: Tristram Gräbener <[email protected]>
@github-actions github-actions bot removed the area:editoast Work on Editoast Service label Feb 12, 2025
@Tristramg Tristramg enabled auto-merge February 12, 2025 15:11
@Tristramg Tristramg added this pull request to the merge queue Feb 12, 2025
@Tristramg Tristramg self-assigned this Feb 12, 2025
Merged via the queue into dev with commit 3f83ed4 Feb 12, 2025
27 checks passed
@Tristramg Tristramg deleted the remove_blueprint branch February 12, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants