Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add paced trains #10772

Merged
merged 5 commits into from
Feb 25, 2025
Merged

front: add paced trains #10772

merged 5 commits into from
Feb 25, 2025

Conversation

SharglutDev
Copy link
Contributor

close #10607

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.47514% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (ad52665) to head (dbee24e).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
...common/BootstrapSNCF/ModalSNCF/ModalHeaderSNCF.tsx 0.00% 6 Missing ⚠️
front/src/common/Tabs.tsx 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10772      +/-   ##
==========================================
+ Coverage   82.53%   82.55%   +0.02%     
==========================================
  Files        1086     1087       +1     
  Lines      107931   108090     +159     
  Branches      740      742       +2     
==========================================
+ Hits        89081    89236     +155     
- Misses      18808    18812       +4     
  Partials       42       42              
Flag Coverage Δ
editoast 74.38% <ø> (+<0.01%) ⬆️
front 90.37% <94.47%> (+0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/add-paced-train branch 10 times, most recently from b93c917 to 15eb0d2 Compare February 18, 2025 19:03
@SharglutDev SharglutDev force-pushed the pfn/front/add-paced-train branch 2 times, most recently from d674e51 to 0201556 Compare February 20, 2025 13:51
@SharglutDev SharglutDev marked this pull request as ready for review February 20, 2025 14:23
@SharglutDev SharglutDev requested review from a team as code owners February 20, 2025 14:23
@SharglutDev SharglutDev requested review from kmer2016 and Yohh February 20, 2025 14:23
@Maymanaf Maymanaf self-requested a review February 20, 2025 15:09
@Yohh Yohh self-assigned this Feb 21, 2025
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !

@SharglutDev SharglutDev force-pushed the pfn/front/add-paced-train branch from 0201556 to ee92c7f Compare February 21, 2025 16:22
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a proposal

I need more time for e2e tests

@SharglutDev SharglutDev force-pushed the pfn/front/add-paced-train branch from e41770e to 51c2ce0 Compare February 24, 2025 09:29
@SharglutDev SharglutDev requested a review from Yohh February 24, 2025 15:26
@SharglutDev SharglutDev force-pushed the pfn/front/add-paced-train branch from 49d4672 to 588e2d2 Compare February 25, 2025 09:58
@SharglutDev SharglutDev force-pushed the pfn/front/add-paced-train branch from 588e2d2 to dbee24e Compare February 25, 2025 10:18
@SharglutDev SharglutDev added this pull request to the merge queue Feb 25, 2025
Merged via the queue into dev with commit 59b064f Feb 25, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/add-paced-train branch February 25, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new paced train
6 participants