Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix undefined markerInfo.op in ItineraryMarkers #10774

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

emersion
Copy link
Member

When launching a pathfinding this error pops up in the console:

Uncaught (in promise) TypeError: markerInfo.op is undefined
    trackId ItineraryMarkers.tsx:132
    fetchTrackSections ItineraryMarkers.tsx:132
    ItineraryMarkers ItineraryMarkers.tsx:136

Before SuggestedOP are fetched, markerInfo.op is undefined.

Guard against undefined values to avoid the error.

When launching a pathfinding this error pops up in the console:

    Uncaught (in promise) TypeError: markerInfo.op is undefined
        trackId ItineraryMarkers.tsx:132
        fetchTrackSections ItineraryMarkers.tsx:132
        ItineraryMarkers ItineraryMarkers.tsx:136

Before SuggestedOP are fetched, markerInfo.op is undefined.

Guard against undefined values to avoid the error.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested review from clarani and theocrsb February 11, 2025 17:18
@emersion emersion requested a review from a team as a code owner February 11, 2025 17:18
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 11, 2025
@emersion emersion self-assigned this Feb 11, 2025
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion emersion added this pull request to the merge queue Feb 12, 2025
Merged via the queue into dev with commit c46f4a5 Feb 12, 2025
53 checks passed
@emersion emersion deleted the emr/marker-op-undef branch February 12, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants