Add missing CH codes on the DPY-MAS axis #10779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Rolland <[email protected]>
axrolld
force-pushed
the
ard/add-missing-ch-codes
branch
from
5418234 to
97bbef0
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10779 +/- ##
==========================================
+ Coverage 81.94% 81.96% +0.02%
==========================================
Files 1077 1077
Lines 107480 107624 +144
Branches 727 727
==========================================
+ Hits 88071 88211 +140
- Misses 19370 19374 +4
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmer2016
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
I haven't tried it locally cause i don't have osrd setup. Could you please make sure the new OPs are selectable in LMR when reviewing the PR ? Thanks a lot 🙏
Users told us we were missing some OPs in our infrastructure. After @Arthur-Lefebvre 's investigation it seems like we were missing some OPs indeed. This PR adds them in the LMR whitelist.
Closes #10778