Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: extend use of osrdErrorType.isRecoverable #10801

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

bougue-pe
Copy link
Contributor

Improve the expressiveness when handling exceptions in rabbit worker. After #10594 and #9439.

Also minor code/log improvements.

Improve the expressiveness when handling exceptions in rabbit worker.
After #10594 and
#9439.

Also minor code/log improvements.

Signed-off-by: Pierre-Etienne Bougué <[email protected]>
@bougue-pe bougue-pe requested a review from a team as a code owner February 13, 2025 17:33
@bougue-pe bougue-pe requested a review from Khoyo February 13, 2025 17:33
@github-actions github-actions bot added the area:core Work on Core Service label Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (9badbe7) to head (9f298ea).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10801      +/-   ##
==========================================
+ Coverage   81.86%   81.93%   +0.06%     
==========================================
  Files        1082     1083       +1     
  Lines      107123   107554     +431     
  Branches      721      741      +20     
==========================================
+ Hits        87697    88121     +424     
- Misses      19385    19392       +7     
  Partials       41       41              
Flag Coverage Δ
editoast 74.31% <ø> (-0.02%) ⬇️
front 89.46% <ø> (+0.06%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.91% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bougue-pe bougue-pe added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit daa5eae Feb 14, 2025
27 checks passed
@bougue-pe bougue-pe deleted the peb/core/rabbit_worker_cleanup branch February 14, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants