Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: no longer display destination on single step path #10803

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 13, 2025

Close #10115

(Although single step schedules seem kind of nonsensical to me in the first place)

@Synar Synar requested a review from a team as a code owner February 13, 2025 23:19
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (3f83ed4) to head (f035510).
Report is 28 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10803      +/-   ##
==========================================
+ Coverage   81.83%   81.93%   +0.09%     
==========================================
  Files        1081     1083       +2     
  Lines      106882   107554     +672     
  Branches      729      741      +12     
==========================================
+ Hits        87469    88125     +656     
- Misses      19372    19388      +16     
  Partials       41       41              
Flag Coverage Δ
editoast 74.32% <ø> (+<0.01%) ⬆️
front 89.46% <100.00%> (+0.08%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.91% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested :)

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

@Synar Synar added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit 90dc639 Feb 14, 2025
27 checks passed
@Synar Synar deleted the ali/fix-destination-displayed-on-single-step-path branch February 14, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train schedules with one path step handled weirdly
4 participants