Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: use Duration in TrainScheduleWithDetails.duration #10806

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

emersion
Copy link
Member

This is more strongly typed.

@emersion emersion requested a review from a team as a code owner February 14, 2025 09:13
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 14, 2025
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and lgtm !

This is more strongly typed.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion force-pushed the emr/train-sch-details-dur branch from 68d1e2a to a9adb34 Compare February 14, 2025 11:51
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested ✅

@emersion emersion added this pull request to the merge queue Feb 14, 2025
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of the Duration class
(reviewed only)

Merged via the queue into dev with commit 2fe13cf Feb 14, 2025
27 checks passed
@emersion emersion deleted the emr/train-sch-details-dur branch February 14, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants