Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix some /dist imports from ui-spacetimechart #10809

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Feb 14, 2025

Since bump of osrd-ui 0.0.66, we can fix these

Note

There are still remaining /dist imports from osrd-ui (mainly from ui-speedspacechart)

@SharglutDev SharglutDev self-assigned this Feb 14, 2025
@SharglutDev SharglutDev requested a review from a team as a code owner February 14, 2025 09:54
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.95%. Comparing base (d1d32ae) to head (b574175).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10809      +/-   ##
==========================================
+ Coverage   81.93%   81.95%   +0.01%     
==========================================
  Files        1083     1083              
  Lines      107559   107622      +63     
  Branches      741      741              
==========================================
+ Hits        88131    88198      +67     
+ Misses      19387    19383       -4     
  Partials       41       41              
Flag Coverage Δ
editoast 74.39% <ø> (+0.06%) ⬆️
front 89.46% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SharglutDev SharglutDev added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit f8d3042 Feb 14, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-spacetimechart-dist-imports branch February 14, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants