Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix map markers react warning for duplicate keys #10811

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

SharglutDev
Copy link
Contributor

fix #10810

@SharglutDev SharglutDev requested review from Synar and clarani February 14, 2025 10:26
@SharglutDev SharglutDev requested a review from a team as a code owner February 14, 2025 10:26
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.85%. Comparing base (d1d32ae) to head (0c418fa).
Report is 26 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10811      +/-   ##
==========================================
- Coverage   81.93%   81.85%   -0.08%     
==========================================
  Files        1083     1083              
  Lines      107559   107175     -384     
  Branches      741      741              
==========================================
- Hits        88131    87731     -400     
- Misses      19387    19403      +16     
  Partials       41       41              
Flag Coverage Δ
editoast 74.38% <ø> (+0.05%) ⬆️
front 89.37% <100.00%> (-0.10%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (+0.07%) ⬆️
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Synar Synar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^^

(I don't have an opinion on the index vs index+coord key, either choice seems fine to me)

@SharglutDev SharglutDev force-pushed the pfn/front/fix-mapmarkers-warning branch from be8c941 to 0c418fa Compare February 14, 2025 14:51
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SharglutDev SharglutDev added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit 798c97f Feb 14, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-mapmarkers-warning branch February 14, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React key warning for MapMarkers
4 participants