Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix infra editor switch list display #10815

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 14, 2025

Close #8301

(Nothing about <CheckboxRadioSNCF> was changed, it was simply placed in a div with padding)

@Synar Synar requested a review from a team as a code owner February 14, 2025 16:10
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (3af0ded) to head (153a395).
Report is 22 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10815      +/-   ##
==========================================
- Coverage   81.87%   81.87%   -0.01%     
==========================================
  Files        1083     1083              
  Lines      107157   107254      +97     
  Branches      741      738       -3     
==========================================
+ Hits        87734    87811      +77     
- Misses      19382    19402      +20     
  Partials       41       41              
Flag Coverage Δ
editoast 74.38% <ø> (-0.01%) ⬇️
front 89.38% <100.00%> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Synar Synar added this pull request to the merge queue Feb 17, 2025
Merged via the queue into dev with commit cf4a914 Feb 17, 2025
27 checks passed
@Synar Synar deleted the ali/fix-infra-editor-switch-list-display branch February 17, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra editor : Speed restriction editor translation problem on selector
4 participants