Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: rename etcs signal to stop marker #10816

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Feb 14, 2025

image

@flomonster flomonster requested a review from a team as a code owner February 14, 2025 17:11
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (c38d369) to head (2244e54).
Report is 36 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10816      +/-   ##
==========================================
- Coverage   82.60%   82.60%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107444   107444              
  Branches      729      729              
==========================================
- Hits        88756    88750       -6     
- Misses      18646    18652       +6     
  Partials       42       42              
Flag Coverage Δ
editoast 74.39% <ø> (-0.02%) ⬇️
front 90.51% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster requested a review from Tristramg February 14, 2025 17:15
@Tristramg
Copy link
Contributor

Sorry, I don’t know how to test it either. Apparently it’s still work in progress. To show that we incorporated the icons, I just replaced tvm icons by etcs 😬

@flomonster flomonster self-assigned this Feb 18, 2025
@flomonster flomonster force-pushed the fam/rename-etcs-signal branch from c0e64fd to 7ad8643 Compare February 20, 2025 13:40
@flomonster flomonster force-pushed the fam/rename-etcs-signal branch from 7ad8643 to 2244e54 Compare February 20, 2025 14:53
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm not tested

@flomonster flomonster added this pull request to the merge queue Feb 24, 2025
Merged via the queue into dev with commit 4597609 Feb 24, 2025
27 checks passed
@flomonster flomonster deleted the fam/rename-etcs-signal branch February 24, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants