Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sprite generation directory #10824

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Fix sprite generation directory #10824

merged 1 commit into from
Feb 17, 2025

Conversation

Tristramg
Copy link
Contributor

No description provided.

@Tristramg Tristramg requested a review from a team as a code owner February 14, 2025 17:52
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 14, 2025
@Tristramg Tristramg force-pushed the fix_sprite_asset_generation branch from 3b8aa46 to 4052b2a Compare February 14, 2025 17:52
@Tristramg Tristramg requested a review from flomonster February 14, 2025 17:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (beff514) to head (85a0f67).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10824      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107212   107216       +4     
  Branches      737      737              
==========================================
  Hits        87842    87842              
- Misses      19329    19333       +4     
  Partials       41       41              
Flag Coverage Δ
editoast 74.37% <ø> (-0.02%) ⬇️
front 89.49% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tristramg Tristramg force-pushed the fix_sprite_asset_generation branch 2 times, most recently from a751ab3 to 02910f8 Compare February 15, 2025 08:01
@flomonster flomonster changed the title editoast: fix sprite generation directory Fix sprite generation directory Feb 17, 2025
@Tristramg Tristramg force-pushed the fix_sprite_asset_generation branch from 02910f8 to a9becff Compare February 17, 2025 10:02
@Tristramg Tristramg force-pushed the fix_sprite_asset_generation branch from a9becff to 85a0f67 Compare February 17, 2025 10:11
@Tristramg Tristramg enabled auto-merge February 17, 2025 10:28
@Tristramg Tristramg added this pull request to the merge queue Feb 17, 2025
Merged via the queue into dev with commit d1389d4 Feb 17, 2025
27 checks passed
@Tristramg Tristramg deleted the fix_sprite_asset_generation branch February 17, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants