Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stop heating the room when selecting a train #10830

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

emersion
Copy link
Member

Spring is coming.

We were generating the PDF report (rendering and all) each time a train was selected. Instead, only generate the PDF when the user clicks the download button.

image

Spring is coming.

We were generating the PDF report (rendering and all) each time a
train was selected. Instead, only generate the PDF when the user
clicks the download button.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested a review from a team as a code owner February 17, 2025 13:48
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 17, 2025
@emersion emersion self-assigned this Feb 17, 2025
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@emersion emersion added this pull request to the merge queue Feb 17, 2025
Merged via the queue into dev with commit a6ccb06 Feb 17, 2025
27 checks passed
@emersion emersion deleted the emr/xbcd-1172 branch February 17, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants