Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix comments and reformat 'Cargo.toml' #10831

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

woshilapin
Copy link
Contributor

The comment is not targetting the correct dependency, and the order of dependency is kind of weird
(opentelemetry is far away from its friends).

The comment is not targetting the correct dependency,
and the order of dependency is kind of weird
(`opentelemetry` is far away from its friends).

Signed-off-by: Jean SIMARD <[email protected]>
@woshilapin woshilapin requested a review from a team as a code owner February 17, 2025 14:35
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (f1b10fb) to head (bb75f62).
Report is 17 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10831      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107199   107199              
  Branches      737      737              
==========================================
- Hits        87832    87827       -5     
- Misses      19326    19331       +5     
  Partials       41       41              
Flag Coverage Δ
editoast 74.36% <ø> (-0.02%) ⬇️
front 89.49% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin woshilapin enabled auto-merge February 17, 2025 14:53
@woshilapin woshilapin added this pull request to the merge queue Feb 18, 2025
Merged via the queue into dev with commit 3e1768d Feb 18, 2025
27 checks passed
@woshilapin woshilapin deleted the wsl/editoast/reformat-toml branch February 18, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants