Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: use cache mount for npm install #10835

Merged
merged 1 commit into from
Feb 18, 2025
Merged

docker: use cache mount for npm install #10835

merged 1 commit into from
Feb 18, 2025

Conversation

emersion
Copy link
Member

This should avoid re-downloading dependencies when re-building the container.

@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:gateway labels Feb 17, 2025
@emersion emersion self-assigned this Feb 17, 2025
@emersion emersion marked this pull request as ready for review February 17, 2025 20:16
@emersion emersion requested review from a team as code owners February 17, 2025 20:16
ElysaSrc
ElysaSrc previously requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@ElysaSrc ElysaSrc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sed the cache out on GitHub Actions due to its instability. We already do it for other components.

@Khoyo
Copy link
Contributor

Khoyo commented Feb 18, 2025

Yeah, you just need to adapt the pattern on the find to include Dockerfile.playwright

@emersion
docker: use cache mount for npm install
7f03aed 
This should avoid re-downloading dependencies when re-building the
container.

Signed-off-by: Simon Ser <[email protected]>
@github-actions github-actions bot added the area:ci Work on Continous Integration Pipeline Service label Feb 18, 2025
@emersion
Copy link
Member Author

We should sed the cache out on GitHub Actions due to its instability. We already do it for other components.

Oh right! I thought this was already performed for all Dockerfiles, but the find invocation was missing Dockerfile.*. Fixed!

@emersion emersion requested a review from kmer2016 February 18, 2025 12:53
@emersion emersion added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@Khoyo Khoyo added this pull request to the merge queue Feb 18, 2025
Merged via the queue into dev with commit 7eeaeca Feb 18, 2025
27 checks passed
@Khoyo Khoyo deleted the emr/npm-cache branch February 18, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khoyo Khoyo Khoyo approved these changes

@kmer2016 kmer2016 kmer2016 approved these changes

@ElysaSrc ElysaSrc ElysaSrc left review comments

Assignees

@emersion emersion

Labels
area:ci Work on Continous Integration Pipeline Service area:front Work on Standard OSRD Interface modules area:gateway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emersion @Khoyo @kmer2016 @ElysaSrc