Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add speedlimits boundaries to simulation export to csv #10837

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 17, 2025

Close #9346

@Synar Synar requested a review from a team as a code owner February 17, 2025 20:48
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (f1b10fb) to head (02974c0).
Report is 43 commits behind head on dev.

Files with missing lines Patch % Lines
...s/simulationResult/SimulationResultExport/utils.ts 71.42% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10837      +/-   ##
==========================================
+ Coverage   81.93%   82.56%   +0.63%     
==========================================
  Files        1084     1084              
  Lines      107199   107276      +77     
  Branches      737      728       -9     
==========================================
+ Hits        87832    88573     +741     
+ Misses      19326    18662     -664     
  Partials       41       41              
Flag Coverage Δ
editoast 74.38% <ø> (+<0.01%) ⬆️
front 90.47% <94.73%> (+0.97%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar Synar force-pushed the ali/add-speedlimits-boundaries-to-sim-export-csv branch from 5dcda36 to 02974c0 Compare February 17, 2025 21:05
@theocrsb theocrsb requested review from clarani and theocrsb February 18, 2025 12:14
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, not tested ✅

@Synar Synar added this pull request to the merge queue Feb 19, 2025
Merged via the queue into dev with commit 85702d1 Feb 19, 2025
27 checks passed
@Synar Synar deleted the ali/add-speedlimits-boundaries-to-sim-export-csv branch February 19, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulation result as csv export missing speed limit transitions
4 participants