-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add categories to rolling stock edit endpoint #10840
editoast: add categories to rolling stock edit endpoint #10840
Conversation
Signed-off-by: hamz2a <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10840 +/- ##
==========================================
+ Coverage 81.93% 82.59% +0.66%
==========================================
Files 1084 1084
Lines 107212 107375 +163
Branches 737 729 -8
==========================================
+ Hits 87842 88690 +848
+ Misses 19329 18643 -686
- Partials 41 42 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
25cf99b
to
6748c83
Compare
Signed-off-by: hamz2a <[email protected]>
6748c83
to
bf88b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice bug fix!
c7193ba
to
17f06d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just one nitpick ^^
17f06d3
to
9115891
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Signed-off-by: hamz2a <[email protected]>
9115891
to
24f3814
Compare
Part of #10574
primary_category
is not included inother_categories
.