Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add categories to rolling stock edit endpoint #10840

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Feb 18, 2025

Part of #10574

  • Add the columns to edit endpoints
  • Check that primary_category is not included in other_categories.

@hamz2a hamz2a requested a review from a team as a code owner February 18, 2025 09:55
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 18, 2025
@hamz2a hamz2a self-assigned this Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.96491% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (beff514) to head (24f3814).
Report is 51 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/models/rolling_stock_model.rs 85.18% 12 Missing ⚠️
front/src/modules/rollingStock/helpers/utils.ts 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10840      +/-   ##
==========================================
+ Coverage   81.93%   82.59%   +0.66%     
==========================================
  Files        1084     1084              
  Lines      107212   107375     +163     
  Branches      737      729       -8     
==========================================
+ Hits        87842    88690     +848     
+ Misses      19329    18643     -686     
- Partials       41       42       +1     
Flag Coverage Δ
editoast 74.42% <88.88%> (+0.03%) ⬆️
front 90.51% <33.33%> (+1.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-add-categories-to-rolling-stock-edit-endpoint branch from 25cf99b to 6748c83 Compare February 18, 2025 10:24
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 18, 2025
@hamz2a hamz2a force-pushed the hai/editoast-add-categories-to-rolling-stock-edit-endpoint branch from 6748c83 to bf88b05 Compare February 18, 2025 10:54
@hamz2a hamz2a requested a review from a team as a code owner February 18, 2025 10:54
@SharglutDev SharglutDev requested a review from Synar February 18, 2025 13:45
@hamz2a hamz2a requested a review from a team as a code owner February 18, 2025 14:20
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bug fix!

@hamz2a hamz2a force-pushed the hai/editoast-add-categories-to-rolling-stock-edit-endpoint branch from c7193ba to 17f06d3 Compare February 18, 2025 14:33
Copy link
Contributor

@Synar Synar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just one nitpick ^^

@hamz2a hamz2a force-pushed the hai/editoast-add-categories-to-rolling-stock-edit-endpoint branch from 17f06d3 to 9115891 Compare February 18, 2025 16:22
@hamz2a hamz2a requested a review from Maymanaf February 19, 2025 09:39
@hamz2a hamz2a requested a review from SharglutDev February 19, 2025 09:46
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks !

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@hamz2a hamz2a force-pushed the hai/editoast-add-categories-to-rolling-stock-edit-endpoint branch from 9115891 to 24f3814 Compare February 19, 2025 13:26
@github-actions github-actions bot added the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Feb 19, 2025
@hamz2a hamz2a added this pull request to the merge queue Feb 19, 2025
Merged via the queue into dev with commit 8ebfe52 Feb 19, 2025
27 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-categories-to-rolling-stock-edit-endpoint branch February 19, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants