front: drop calculateTimeDifferenceInSeconds() and datetime2string() #10843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more type-safe, and will allow us to manipulate the value with Duration helpers. Signed-off-by: Simon Ser <[email protected]>
Useful for the next commit. Signed-off-by: Simon Ser <[email protected]>
Replace number operations and unit conversions with Duration operations. This is the only user of calculateTimeDifferenceInSeconds(). That function duplicates the functionality of Duration.subtractDate(). Signed-off-by: Simon Ser <[email protected]>
This is now unused. Signed-off-by: Simon Ser <[email protected]>
This is unused. Signed-off-by: Simon Ser <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.