Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: stdcm_log: store requests that cause core errors #10847

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Feb 18, 2025

Fixes #10841.

@Khoyo Khoyo requested a review from a team as a code owner February 18, 2025 12:47
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 18, 2025
@Khoyo Khoyo marked this pull request as draft February 18, 2025 12:48
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (8ebfe52) to head (1d6d796).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/timetable/stdcm.rs 55.55% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10847      +/-   ##
==========================================
- Coverage   82.61%   82.60%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107442   107448       +6     
  Branches      729      729              
==========================================
- Hits        88759    88754       -5     
- Misses      18641    18652      +11     
  Partials       42       42              
Flag Coverage Δ
editoast 74.40% <66.66%> (-0.03%) ⬇️
front 90.51% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo force-pushed the yk/stdcm_log-store-errors branch 2 times, most recently from b3ce48e to 0e5a793 Compare February 18, 2025 15:30
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 18, 2025
@Khoyo Khoyo marked this pull request as ready for review February 18, 2025 15:43
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Khoyo Khoyo force-pushed the yk/stdcm_log-store-errors branch from 157f185 to 6597aae Compare February 19, 2025 15:30
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khoyo Khoyo enabled auto-merge February 19, 2025 16:35
@Khoyo Khoyo force-pushed the yk/stdcm_log-store-errors branch from f2466ba to 1d6d796 Compare February 19, 2025 16:35
@Khoyo Khoyo added this pull request to the merge queue Feb 19, 2025
Merged via the queue into dev with commit 975ec76 Feb 19, 2025
27 checks passed
@Khoyo Khoyo deleted the yk/stdcm_log-store-errors branch February 19, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: stdcm request is not logged when core fails
4 participants