Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: avoid infinite loop in logger edge case #10849

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Feb 18, 2025

See comment for explanation. It triggered with the fuzzer, but I don't think it could have happened in real life conditions.

What made it annoying is that it's an infinite loop that isn't caught by the usual timeout, it would just lock a thread forever.

@eckter eckter requested a review from bougue-pe February 18, 2025 13:39
@eckter eckter requested a review from a team as a code owner February 18, 2025 13:39
@github-actions github-actions bot added the area:core Work on Core Service label Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (f4e0c84) to head (65aa2cc).
Report is 14 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10849      +/-   ##
==========================================
- Coverage   82.56%   82.56%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107256   107256              
  Branches      728      728              
==========================================
- Hits        88558    88557       -1     
- Misses      18657    18658       +1     
  Partials       41       41              
Flag Coverage Δ
editoast 74.39% <ø> (-0.01%) ⬇️
front 90.47% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Feb 18, 2025
Merged via the queue into dev with commit c40cee1 Feb 18, 2025
27 checks passed
@eckter eckter deleted the ech/stdcm-fix-infinite-loop branch February 18, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants