editoast: stdcm improve validation messages #10850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:front
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10850 +/- ##
==========================================
- Coverage 82.60% 82.60% -0.01%
==========================================
Files 1084 1084
Lines 107448 107444 -4
Branches 729 729
==========================================
- Hits 88761 88754 -7
- Misses 18645 18648 +3
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Wadjetz
force-pushed
the
ebe/editoast/lmr-validation-messages
branch
3 times, most recently
from
1ff3603 to
c282985
Compare
|
Nit: can we use "stdcm" instead of "lmr" in commit messages? "LMR" is SNCF-specific wording, as far as the open-source project is concerned this part of the project is still called "STDCM". |
Wadjetz
changed the title
Wadjetz
force-pushed
the
ebe/editoast/lmr-validation-messages
branch
2 times, most recently
from
2805ea5 to
e90ef02
Compare
leovalais
approved these changes
Feb 18, 2025
bougue-pe
reviewed
Feb 18, 2025
Wadjetz
force-pushed
the
ebe/editoast/lmr-validation-messages
branch
2 times, most recently
from
596c792 to
86aac2f
Compare
bougue-pe
reviewed
Feb 19, 2025
Signed-off-by: Egor Berezovskiy <[email protected]>
Wadjetz
force-pushed
the
ebe/editoast/lmr-validation-messages
branch
from
86aac2f to
7f331d5
Compare
woshilapin
approved these changes
Feb 20, 2025
bougue-pe
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #9543
Add better error messages