core: stdcm: fix initialization of fixed time points in postproc #10851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10851 +/- ##
==========================================
- Coverage 82.56% 82.55% -0.02%
==========================================
Files 1084 1084
Lines 107256 107257 +1
Branches 728 729 +1
==========================================
- Hits 88558 88548 -10
- Misses 18657 18667 +10
- Partials 41 42 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bougue-pe
approved these changes
Feb 18, 2025
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/PostProcessingSimulation.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/PostProcessingSimulation.kt
Show resolved
Hide resolved
Erashin
approved these changes
Feb 18, 2025
Fix two issues: we'd accidentally delete the last point (for allowance), and the points at the *start* of allowances can cause issues Signed-off-by: Eloi Charpentier <[email protected]>
eckter
force-pushed
the
ech/fix-stdcm-points
branch
from
30ab027 to
8e73699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues: we'd accidentally delete the last point (for allowance), and the points at the start of allowances can cause issues.
Fix at least some cases of "mismatch during post-processing".