Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: move the deployment settings in high level context #10852

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 18, 2025

closes #10834

@clarani clarani requested a review from a team as a code owner February 18, 2025 14:42
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (f4e0c84) to head (ce6442b).
Report is 32 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10852      +/-   ##
==========================================
+ Coverage   82.56%   82.60%   +0.04%     
==========================================
  Files        1084     1084              
  Lines      107256   107387     +131     
  Branches      728      729       +1     
==========================================
+ Hits        88558    88711     +153     
+ Misses      18657    18634      -23     
- Partials       41       42       +1     
Flag Coverage Δ
editoast 74.39% <ø> (-0.01%) ⬇️
front 90.52% <100.00%> (+0.05%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/10834-logo-is-blinking-on-deployed-env branch from af6959e to 0cd3f6b Compare February 18, 2025 14:58
@clarani clarani force-pushed the cni/10834-logo-is-blinking-on-deployed-env branch from 0cd3f6b to 1d7e8fa Compare February 19, 2025 09:23
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, but very nice solution !

@clarani clarani force-pushed the cni/10834-logo-is-blinking-on-deployed-env branch from 1d7e8fa to 97faafd Compare February 19, 2025 12:46
@clarani clarani requested a review from kmer2016 February 19, 2025 12:47
@clarani clarani force-pushed the cni/10834-logo-is-blinking-on-deployed-env branch from 97faafd to ce6442b Compare February 19, 2025 13:20
@clarani clarani enabled auto-merge February 19, 2025 13:20
@clarani clarani added this pull request to the merge queue Feb 19, 2025
Merged via the queue into dev with commit 6d150d1 Feb 19, 2025
27 checks passed
@clarani clarani deleted the cni/10834-logo-is-blinking-on-deployed-env branch February 19, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: logo is blinking on deployed environments
3 participants