Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: fix sync-openapi.sh #10854

Merged
merged 1 commit into from
Feb 19, 2025
Merged

scripts: fix sync-openapi.sh #10854

merged 1 commit into from
Feb 19, 2025

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Feb 18, 2025

Running the script from the project root causes npm to look for node_modules in the wrong location. This fixes it (and is more consistent with the above cargo usage)

Signed-off-by: Younes Khoudli <[email protected]>
@Khoyo Khoyo requested a review from a team as a code owner February 18, 2025 15:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (b9d58a0) to head (1dbdf56).
Report is 23 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10854   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files        1084     1084           
  Lines      107257   107257           
  Branches      729      729           
=======================================
+ Hits        88557    88558    +1     
+ Misses      18658    18657    -1     
  Partials       42       42           
Flag Coverage Δ
editoast 74.40% <ø> (+<0.01%) ⬆️
front 90.47% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo enabled auto-merge February 18, 2025 16:46
@emersion
Copy link
Member

What does this fix?

@Khoyo
Copy link
Contributor Author

Khoyo commented Feb 19, 2025

Description updated

@Khoyo Khoyo added this pull request to the merge queue Feb 19, 2025
Merged via the queue into dev with commit 5cb804d Feb 19, 2025
27 checks passed
@Khoyo Khoyo deleted the yk/fix-sync-openapi branch February 19, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants