core: prioritize signaling system during pathfinding #10857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10857 +/- ##
==========================================
+ Coverage 82.49% 82.53% +0.04%
==========================================
Files 1084 1086 +2
Lines 107614 107931 +317
Branches 739 740 +1
==========================================
+ Hits 88771 89082 +311
- Misses 18801 18807 +6
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Khoyo
reviewed
Feb 19, 2025
core/kt-osrd-signaling/src/main/kotlin/fr/sncf/osrd/signaling/impl/SigSystemManagerImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-signaling/src/main/kotlin/fr/sncf/osrd/signaling/impl/SigSystemManagerImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-signaling/src/main/kotlin/fr/sncf/osrd/signaling/impl/SigSystemManagerImpl.kt
Outdated
Show resolved
Hide resolved
eckter
reviewed
Feb 19, 2025
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/pathfinding/PathfindingBlocksEndpointV2.kt
Outdated
Show resolved
Hide resolved
Erashin
reviewed
Feb 20, 2025
core/src/test/kotlin/fr/sncf/osrd/pathfinding/PathfindingSignalingTest.kt
Outdated
Show resolved
Hide resolved
eckter
approved these changes
Feb 20, 2025
core/kt-osrd-signaling/src/main/kotlin/fr/sncf/osrd/signaling/impl/SigSystemManagerImpl.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierre-Etienne Bougué <[email protected]>
To be corrected (should prioritize BAL over BAPR) Signed-off-by: Pierre-Etienne Bougué <[email protected]>
When everything else is equal, use the preferred signaling system. Update fail test now that it works. Signaling extra penalty: * is dependant of the duration, not the number of blocks * tries to avoid absorbtion by floating-point Signed-off-by: Pierre-Etienne Bougué <[email protected]>
bougue-pe
force-pushed
the
peb/core/pf_prioritize_signaling
branch
from
2789daa to
888ff46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When everything else is equal, use the preferred signaling system.
Also migrate pathfinding signaling tests to API v2 (and add new tests).
🔍 please review by commit.
Fix #10296