-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: take into account new flag for using speed limits #10859
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10859 +/- ##
==========================================
- Coverage 82.59% 82.48% -0.12%
==========================================
Files 1084 1084
Lines 107320 107637 +317
Branches 729 739 +10
==========================================
+ Hits 88644 88786 +142
- Misses 18634 18809 +175
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6ffa561
to
b890424
Compare
b890424
to
50ad060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Signed-off-by: Alex Rolland <[email protected]> Signed-off-by: Clara Ni <[email protected]>
50ad060
to
f310a47
Compare
Nice catch ! I remove the field from the persist config, so it is not persisted anymore and if a user opens a new tab, the config will have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just wait @SharglutDev to resolve :)
Was waiting for @clarani to rebase but I ended up rebasing in local to test :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested ✅
The idea is to make front end keep this flag when it is present (from a json import for example), and keep its default value otherwise. Not adding anything in the interface.
Fixes #10858
You can test with this trainschedule: