Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix clear ci input does not clear ch input in map op search #10860

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 19, 2025

closes #9519

@clarani clarani requested a review from a team as a code owner February 19, 2025 13:13
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 19, 2025
@clarani clarani requested a review from emersion February 19, 2025 13:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (5cb804d) to head (ef2f299).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##              dev   #10860    +/-   ##
========================================
  Coverage   82.59%   82.60%            
========================================
  Files        1084     1084            
  Lines      107320   107437   +117     
  Branches      729      729            
========================================
+ Hits        88645    88749   +104     
- Misses      18633    18646    +13     
  Partials       42       42            
Flag Coverage Δ
editoast 74.41% <ø> (+0.01%) ⬆️
front 90.51% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani requested a review from Caracol3 February 19, 2025 13:14
@clarani clarani force-pushed the cni/9519-op-search-fix-clear branch from e3a7a29 to ef2f299 Compare February 19, 2025 14:37
@clarani clarani enabled auto-merge February 19, 2025 14:37
@clarani clarani requested review from SharglutDev and removed request for emersion February 20, 2025 08:42
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested ✅

@clarani clarani added this pull request to the merge queue Feb 21, 2025
Merged via the queue into dev with commit 56cb3ae Feb 21, 2025
27 checks passed
@clarani clarani deleted the cni/9519-op-search-fix-clear branch February 21, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operational point search: clear filters does not work
3 participants