-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix various problems related to long rolling stock names #10863
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10863 +/- ##
==========================================
- Coverage 82.47% 82.47% -0.01%
==========================================
Files 1084 1084
Lines 107478 107478
Branches 739 739
==========================================
- Hits 88644 88642 -2
- Misses 18792 18794 +2
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front/src/styles/scss/applications/operationalStudies/_managetrainschedule.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_managetrainschedule.scss
Show resolved
Hide resolved
2a95cc4
to
f5414a9
Compare
676b770
to
e81656b
Compare
e81656b
to
b4f0df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, thank you for these painfull fixes :)
(There are still some weird edge cases but it's unlikely that they happen in a real life use of the app)
…ition Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
…chedule Signed-off-by: Clara Ni <[email protected]>
74f4632
to
329f41f
Compare
@theocrsb can you test again ? I can't reproduce anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. Paul is right about the other use cases.
closes #8439
closes #7278