Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix various problems related to long rolling stock names #10863

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 19, 2025

closes #8439
closes #7278

image

@clarani clarani requested a review from a team as a code owner February 19, 2025 14:31
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (2f1856a) to head (329f41f).
Report is 9 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10863      +/-   ##
==========================================
- Coverage   82.47%   82.47%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107478   107478              
  Branches      739      739              
==========================================
- Hits        88644    88642       -2     
- Misses      18792    18794       +2     
  Partials       42       42              
Flag Coverage Δ
editoast 74.38% <ø> (-0.01%) ⬇️
front 90.31% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani enabled auto-merge February 19, 2025 14:34
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix thanks ! Left just some nit comments.

Also, we open the pandora box with this issue 🙃

Can't see the whole rs name
image

Weird style in the rs card
Capture d’écran du 2025-02-19 17-55-07

Horizontal scroll if the rs name is too long (hiding the action buttons)
Capture d’écran du 2025-02-19 17-53-44

@clarani clarani force-pushed the cni/8439-fix-tabs-width branch from 2a95cc4 to f5414a9 Compare February 20, 2025 14:57
@clarani
Copy link
Contributor Author

clarani commented Feb 20, 2025

I fixed some of the issues:

  • the trains are flipped in the timetable cards
    image

  • the names are not wrapped anymore
    image

  • ellipsis were added in the rolling stock editor as well
    image

I won't go further since these components will soon be removed, if it's fine for you 👍

@clarani clarani force-pushed the cni/8439-fix-tabs-width branch 2 times, most recently from 676b770 to e81656b Compare February 20, 2025 15:06
@clarani clarani requested a review from SharglutDev February 20, 2025 15:06
@clarani clarani force-pushed the cni/8439-fix-tabs-width branch from e81656b to b4f0df6 Compare February 20, 2025 15:09
@clarani clarani changed the title front: fix tabs width in ManageTrainSchedule front: fix various problems related to long rolling stock names Feb 20, 2025
@theocrsb
Copy link
Contributor

I have the impression that there is still some strange behavior when the train name is really long :
image

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you for these painfull fixes :)
(There are still some weird edge cases but it's unlikely that they happen in a real life use of the app)

@clarani clarani force-pushed the cni/8439-fix-tabs-width branch from 74f4632 to 329f41f Compare February 21, 2025 14:54
@clarani
Copy link
Contributor Author

clarani commented Feb 21, 2025

@theocrsb can you test again ? I can't reproduce anymore

@clarani clarani added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Paul is right about the other use cases.

@clarani clarani added this pull request to the merge queue Feb 24, 2025
Merged via the queue into dev with commit 21bcd5d Feb 24, 2025
27 checks passed
@clarani clarani deleted the cni/8439-fix-tabs-width branch February 24, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
4 participants